Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

story/VOGRE-41 #35

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

story/VOGRE-41 #35

wants to merge 2 commits into from

Conversation

jophals
Copy link
Contributor

@jophals jophals commented Dec 20, 2024

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

Create contributors.md file ticket link

Are there any other pull requests that this one depends on?

No

Anything else the reviewer needs to know?

No

@diging-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@jophals
Copy link
Contributor Author

jophals commented Dec 20, 2024

make it so, Jenkins

@jdamerow
Copy link
Member

Missing:

that lists all previous contributors (the ones that were deleted from the “Our team” page).
There are a bunch of people who worked on this. They were listed on the teams page of Vogon (which I think is now deleted, but it should in the history or in the old Vogon repo).

Also, let's add a sentence or two about what this page is. Something along the lines of "Many people have contributed to this project over the years. We especially want to thank Erick Peirson and Taylor Quinn for all their work on this. Besides that, a lot of others have worked on Vogon. This file is an attempt to give credit to all of them."

and then list all of them (you can probably also find names in the repo commit history)

@jdamerow jdamerow closed this Dec 20, 2024
@jophals jophals reopened this Dec 20, 2024
@jophals
Copy link
Contributor Author

jophals commented Dec 20, 2024

some of the people in the repo don't list their names on their GitHub profiles and aren't on our team page. I'm sure you could probably identify them based on their usernames though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants