-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/vspc 271 - Exhibition Configuration: if not exhibition language should be required #348
Open
pooja-thalur
wants to merge
13
commits into
develop
Choose a base branch
from
bug/VSPC-271
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
552a29c
[VSPC-271] creating exhibition object when no exhibition is found
pooja-thalur f36f6d7
Revert "[VSPC-271] creating exhibition object when no exhibition is f…
pooja-thalur 3efa17c
[VSPC-271] added a help icon in exhibition languages field
pooja-thalur 6eaec3a
[VSPC-271] Fixed indentation
pooja-thalur c7a607e
[VSPC-271] fixed indentation
pooja-thalur 1e63a6e
[VSPC-271] added validation
pooja-thalur 4a63ff5
[VSPC-271] adding a class for the form params
pooja-thalur 83a7d13
[VSPC-271] added form validation
pooja-thalur 2db9a6b
[VSPC-271] form validation changes
pooja-thalur fd0f403
[VSPC-271] organised methods
pooja-thalur d0c932f
[VSPC-271] addressed pr comments
pooja-thalur 56c777d
[VSPC-271] addressed pr comment
pooja-thalur d36d916
[VSPC-271] addressed pr comments
pooja-thalur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
vspace/src/main/java/edu/asu/diging/vspace/web/staff/forms/ExhibitionConfigurationForm.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
package edu.asu.diging.vspace.web.staff.forms; | ||
|
||
import java.util.List; | ||
|
||
import javax.validation.constraints.NotEmpty; | ||
import javax.validation.constraints.NotNull; | ||
|
||
import edu.asu.diging.vspace.core.model.ExhibitionModes; | ||
|
||
public class ExhibitionConfigurationForm { | ||
|
||
private String customMessage; | ||
|
||
private String defaultExhibitLanguage; | ||
|
||
@NotEmpty(message = "Please select exhibition languages") | ||
private List<String> exhibitLanguage; | ||
|
||
@NotNull(message = "Please select exhibit mode") | ||
private ExhibitionModes exhibitMode; | ||
|
||
@NotEmpty(message = "Please enter title") | ||
private String title; | ||
|
||
public String getCustomMessage() { | ||
return customMessage; | ||
} | ||
|
||
public void setCustomMessage(String customMessage) { | ||
this.customMessage = customMessage; | ||
} | ||
|
||
public String getDefaultExhibitLanguage() { | ||
return defaultExhibitLanguage; | ||
} | ||
|
||
public void setDefaultExhibitLanguage(String defaultExhibitLanguage) { | ||
this.defaultExhibitLanguage = defaultExhibitLanguage; | ||
} | ||
|
||
public List<String> getExhibitLanguage() { | ||
return exhibitLanguage; | ||
} | ||
|
||
public void setExhibitLanguage(List<String> exhibitLanguage) { | ||
this.exhibitLanguage = exhibitLanguage; | ||
} | ||
|
||
public ExhibitionModes getExhibitMode() { | ||
return exhibitMode; | ||
} | ||
|
||
public void setExhibitMode(ExhibitionModes exhibitMode) { | ||
this.exhibitMode = exhibitMode; | ||
} | ||
|
||
public String getTitle() { | ||
return title; | ||
} | ||
|
||
public void setTitle(String title) { | ||
this.title = title; | ||
} | ||
jdamerow marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is not really a reason to save 3 characters, just write out "exhibition" (and in the message it definitely need to be written out)