Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story/vspc 208 #341
base: develop
Are you sure you want to change the base?
Story/vspc 208 #341
Changes from 110 commits
7f6dc06
efffdaa
bbfe3d8
96df53e
95a03e1
4d434db
c69e265
c71368c
46ba692
abbc260
301ed4c
949999d
d65016e
c05d011
c02f795
782b1f0
5b24201
06936e9
9cd2331
f9cb545
f0afaad
ec5b455
a36c852
e391851
fff11aa
2f00e2c
4870da9
9f401c0
18e8fc1
47e5029
e8cdd0c
e1ba617
305e14e
62a04c9
6949fcd
72ffe3f
7ff86ba
aeed62a
74e1915
5be7820
c0c2004
22ac299
5c87eb7
58b37fa
5edf002
a2104cb
2f42ccb
5b9c6f5
aaf1332
7ce57fa
dc63645
f251edf
3733bac
f583d7a
77f770b
4576101
dd97b30
936c04e
abbe9d9
4519395
0ddc6f4
73602fa
8473445
08ad4f6
51e9547
27a2e92
4ac3440
854ace9
964c54e
5f33152
1482735
8f4713d
b968db9
4ad972e
54b66fa
fe4438c
d58889e
9676263
5f80f11
7935521
894ebd9
aa23813
9876314
5aa51a3
b3c9979
5b1fd5b
170cbce
fb201e0
eee5ed8
6ccf6c9
61e9139
3b6eab3
9ee5d7a
0d6e7bb
e2f95af
7a4a0d0
e677be3
2c5e586
74a8474
945290f
e898247
3966fbf
814741e
6be13b0
1e47eaf
6925d29
e281969
5154844
2bb0739
057b477
6436850
0244148
27f9f3e
50c7cd4
6e9de01
af68d29
949abb9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what file location? this is confusing. the method only gets an image and a filename, right? nothing about location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is the case and the image can't be stored, the vsimage object should not be stored either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in line 291 deleting the vsimage object if an exception occurs, as we are using its id to store the image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API endpoints should be in the api package.