Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSPC-199] Fixed the link issue with null targetSpace #272

Merged
merged 4 commits into from
Jan 19, 2022
Merged

Conversation

pradeep-017
Copy link
Contributor

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

Links don't load on space staff page - When a linked space is deleted, the staff site crashes while showing the links over space.

Anything else the reviewer needs to know?

... describe here ...

@diging-jenkins
Copy link

Can one of the admins verify this patch?

@jdamerow
Copy link
Member

Make it so, Jenkins.

@jdamerow
Copy link
Member

Make it so, Jenkins.

@jdamerow
Copy link
Member

Make it so, Jenkins.

@jdamerow jdamerow merged commit 06f8277 into master Jan 19, 2022
@jdamerow jdamerow deleted the bug/VSPC-199 branch January 19, 2022 15:25
jdamerow added a commit that referenced this pull request Dec 1, 2023
* [VSPC-199] Fixed the link issue with null targetSpace (#272)

* [VSPC-199] Fixed the link issue with null targetSpace

* [VSPC-199] Making changes more DRY

* [VSPC-199] reverse OR arguments

* [VSPC-199] Added title for inactive links

Co-authored-by: Julia Damerow <[email protected]>

* [VSPC-233] added backend to store color

* VSPC-233 html input color wheel

* [VSPC-233] text color applied

* [VSPC-233] update color workig

* [VSPC-233] added dynamic color to borders

* [VSPC-233] change border-color

* [VSPC-233] border color working

* [VSPC-233] refactor

---------

Co-authored-by: Julia Damerow <[email protected]>
Co-authored-by: Pradeep Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants