Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/vspc 177 (#238) #239

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Bug/vspc 177 (#238) #239

merged 1 commit into from
Aug 10, 2021

Conversation

jdamerow
Copy link
Member

@jdamerow jdamerow commented Aug 10, 2021

  • VSPC-177 fixed registration issue; attempt to fix space not found

fixed issue when no exhibition mode has been set yet

  • VSPC-177 removed commented out code

  • VSPC-177 fixed test cases

  • VSPC-177 catch exception if incomplete spacelinks exist in the data

  • VSPC-177 ignore if no source space exists

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

(you can copy the ticket if it hasn't changed)

...Put description here...

Anything else the reviewer needs to know?

... describe here ...

* [VSPC-177] fixed registration issue; attempt to fix space not found

fixed issue when no exhibition mode has been set yet

* [VSPC-177] removed commented out code

* [VSPC-177] fixed test cases

* [VSPC-177] catch exception if incomplete spacelinks exist in the data

* [VSPC-177] ignore if no source space exists
@jdamerow jdamerow merged commit 68e32b8 into master Aug 10, 2021
@diging-jenkins
Copy link

Build failed. Maybe you broke the test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants