Story/cite 183 - For authors, editors, etc. there needs to be an import from the IsisCB #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Make it so, Jenkins. |
|
Jenkins successfully deployed Citesphere to be reviewed! |
jdamerow
requested changes
Nov 26, 2024
citesphere/pom.xml
Outdated
| @@ -100,6 +100,10 @@ | |||
| <javers.default.author>Sync Process</javers.default.author> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
|
|
|||
| <isiscb.url>http://isiscb-staging-p3-2.us-west-2.elasticbeanstalk.com/rest/</isiscb.url> | |||
There was a problem hiding this comment.
(and by that I mean the value)
| AuthoritySearchResult searchResult = new AuthoritySearchResult(); | ||
|
|
||
| if (response.getStatusCode() != HttpStatus.OK) { | ||
| throw new AuthorityServiceConnectionException(response.getStatusCode().toString()); |
There was a problem hiding this comment.
if there is a body you probably want to include that in the exception
| return searchResult; | ||
| } | ||
|
|
||
| private String getIsiscbSearchString(String firstName, String lastName) { |
| } | ||
|
|
||
| @Override | ||
| public AuthoritySearchResult searchAuthorities(String firstName, String lastName, int page, int pageSize) |
|
Jenkins successfully deployed Citesphere to be reviewed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
Right now, when adding/editing an author, editor, etc. an authority from Conceptpower or VIAF can be linked to it. There should be a third option to link it to an authority from the IsisCB.
The endpoint to query is:
rest/authority/search/?query=einsteinTalk to Julia before starting to get you set up on the test server.
... Put ticket description here and add link to ticket ...
https://diging.atlassian.net/browse/CITE-183
Are there any other pull requests that this one depends on?
Anything else the reviewer needs to know?
IsisCB API is not returning anything as of now because of some recent updates made to it.
... describe here ...