-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story/cite 223 - DOI field should be shown on citation pages #277
base: develop
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
citesphere/pom.xml
Outdated
<citesphere.messages.version>0.4</citesphere.messages.version> | ||
<citesphere.model.version>1.19</citesphere.model.version> | ||
<citesphere.model.version>1.22-SNAPSHOT</citesphere.model.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
versions don't exist
Make it so, Jenkins. |
DOI (probably also ISSN) is not showing up; also, those fields are not shown when editing. |
Make it so, Jenkins. |
Jenkins successfully deployed Citesphere to be reviewed! |
Still doesn't seem to work. ISSN for instance is not showing up. |
This is working for me on local. It's dependent on - diging/spring-social-zotero#23. Maybe after that PR is merged, this will work in review. |
Jenkins successfully deployed Citesphere to be reviewed! |
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]
into[x]
).Please provide a brief description of your ticket
... Put ticket description here and add link to ticket ...
DOI field should be shown on citation pages
https://diging.atlassian.net/browse/CITE-223
Are there any other pull requests that this one depends on?
diging/spring-social-zotero#23
Anything else the reviewer needs to know?
... describe here ...