Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story/cite 223 - DOI field should be shown on citation pages #277

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

PradnyaC11
Copy link
Contributor

@PradnyaC11 PradnyaC11 commented Jul 29, 2024

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

... Put ticket description here and add link to ticket ...
DOI field should be shown on citation pages

https://diging.atlassian.net/browse/CITE-223

Are there any other pull requests that this one depends on?

diging/spring-social-zotero#23

Anything else the reviewer needs to know?

... describe here ...

@diging-jenkins
Copy link

Can one of the admins verify this patch?

<citesphere.messages.version>0.4</citesphere.messages.version>
<citesphere.model.version>1.19</citesphere.model.version>
<citesphere.model.version>1.22-SNAPSHOT</citesphere.model.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versions don't exist

@jdamerow jdamerow closed this Sep 17, 2024
@PradnyaC11 PradnyaC11 reopened this Sep 24, 2024
@PradnyaC11 PradnyaC11 requested a review from jdamerow September 25, 2024 15:05
@jdamerow
Copy link
Member

Make it so, Jenkins.

@jdamerow
Copy link
Member

DOI (probably also ISSN) is not showing up; also, those fields are not shown when editing.

@jdamerow jdamerow closed this Sep 26, 2024
@PradnyaC11 PradnyaC11 reopened this Oct 29, 2024
@jdamerow
Copy link
Member

Make it so, Jenkins.

@diging-jenkins
Copy link

Jenkins successfully deployed Citesphere to be reviewed!

@jdamerow
Copy link
Member

Still doesn't seem to work. ISSN for instance is not showing up.

@jdamerow jdamerow closed this Nov 26, 2024
@PradnyaC11
Copy link
Contributor Author

This is working for me on local. It's dependent on - diging/spring-social-zotero#23. Maybe after that PR is merged, this will work in review.

@PradnyaC11 PradnyaC11 reopened this Dec 5, 2024
@diging-jenkins
Copy link

Jenkins successfully deployed Citesphere to be reviewed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants