Story/cico 13 #11
Closed
Story/cico 13 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommit, started working on fixing add_item method, updated requirements.txt, started working on PyPi structure
|
Created new PR to track all tickets related to CICO-6 |
…, updated .toml file, added some tests
jdamerow
requested changes
Dec 20, 2024
There was a problem hiding this comment.
I don't think this action is doing anything? Just checking out and installing ruff?
There was a problem hiding this comment.
Also, the action should run the tests.
|
|
||
| For retrieivng the Bearer access token required for endpoint method calls, please see the following OAuth2 [documentation] (https://diging.atlassian.net/wiki/spaces/OAC/pages/3533078792/Getting+OAuth2+Access+Token+in+Postman) for Citesphere | ||
|
|
There was a problem hiding this comment.
I think the pre-commit hooks need to be installed too, don't they?
|
|
||
| [project.urls] | ||
| "Citesphere API" = "https://documenter.getpostman.com/view/19365454/UVeMJiyx" | ||
| "Citesphere" = "https://diging-dev.asu.edu/citesphere-review/" |
| pre_commit==4.0.1 | ||
| PyYAML==6.0.2 | ||
| ruff==0.7.4 | ||
| virtualenv==20.27.1 |
There was a problem hiding this comment.
I don't think this needs to be installed?
There was a problem hiding this comment.
And does it really need all these dependencies?
| python_requires=">=3.9", | ||
| project_urls={ | ||
| "Citesphere API": "https://documenter.getpostman.com/view/19365454/UVeMJiyx", | ||
| "Citesphere": "https://diging-dev.asu.edu/citesphere-review/", |
There was a problem hiding this comment.
pychache folder should not be pushed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
(you can copy the ticket if it hasn't changed)
Update and clean up CitesphereConnector
Anything else the reviewer needs to know?