Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't set labelNames when getCounterMetric #37

Open
yakiang opened this issue Aug 18, 2020 · 1 comment
Open

can't set labelNames when getCounterMetric #37

yakiang opened this issue Aug 18, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone
0.2.6

Comments

@yakiang
Copy link

yakiang commented Aug 18, 2020

getCounterMetric only accept name as params, and inside it calls findOrCreateCounter with the name, but findOrCreateCounter can accept labelNames as well.
When I call counter.inc({ uri: '/abc' }, 1), it throws error:
Added label "uri" is not included in initial labelset: []
@spike008t spike008t added the enhancement New feature or request label Oct 23, 2020
@spike008t spike008t added this to the 0.2.6 milestone Oct 23, 2020
spike008t added a commit that referenced this issue Oct 23, 2020
@spike008t
fix(service): add labelNames argument on promService get metric
fb846fd 
Close #37
This was referenced Oct 23, 2020
Merged
Open
@spike008t
Copy link
Contributor

Fix will be merge on 0.2.6 soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.6
Development

No branches or pull requests
2 participants
@spike008t @yakiang