Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analytics admin permissions #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ module Decidim
module Analytics
module Admin
class AnalyticsController < Analytics::Admin::ApplicationController

def index
enforce_permission_to :read, :analytics

@server_address = Rails.application.secrets.dig(:matomo, :server_address)
@site_id = Rails.application.secrets.dig(:matomo, :site_id)
@token_auth = Rails.application.secrets.dig(:matomo, :token_auth)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ module Admin
# Note that it inherits from `Decidim::Admin::Components::BaseController`, which
# override its layout and provide all kinds of useful methods.
class ApplicationController < Decidim::Admin::ApplicationController
def permission_class_chain
[::Decidim::Analytics::Admin::Permissions] + super
end
end
end
end
Expand Down
25 changes: 25 additions & 0 deletions app/permissions/decidim/analytics/admin/permissions.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@


# frozen_string_literal: true

module Decidim
module Analytics
module Admin
class Permissions < Decidim::DefaultPermissions
def permissions
return permission_action if permission_action.scope != :admin
return permission_action unless user&.admin?

allow! if read_analytics?

permission_action
end

def read_analytics?
permission_action.subject == :analytics &&
permission_action.action == :read
end
end
end
end
end