feat: convert mbtiles to a styled map package file #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
approved these changes
Nov 18, 2024
| const style = await smp.getStyle('') | ||
| const sourceMetadata = Object.values(style.sources)[0] | ||
| assert.equal(sourceMetadata.type, 'raster') | ||
| for (const { x, y, z, data } of mbtiles) { |
There was a problem hiding this comment.
Maybe worth verifying that mbtiles is nonempty?
test/from-mbtiles.js
Outdated
| * @param {Record<string, string | number>} variables - An object where the keys correspond to variable names and values correspond to the replacement values. | ||
| * @returns {string} The string with the variables replaced by their corresponding values. | ||
| */ | ||
| export function replaceVariables(template, variables) { |
There was a problem hiding this comment.
Does this need to be exported?
Suggested change
| export function replaceVariables(template, variables) { | |
| function replaceVariables(template, variables) { |
Comment on lines
+64
to
+66
| const returnValue = outputPath | ||
| ? pipelinePromise(writer.outputStream, fs.createWriteStream(outputPath)) | ||
| : writer.outputStream |
There was a problem hiding this comment.
I don't feel strongly about this, but it feels a little cleaner to have this always take an output stream rather than a path. The command could do this transformation.
There was a problem hiding this comment.
Agreed, however I don't think worth the effort at this stage (would also require updating tests and having a way to test the CLI)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful for when only mbtiles are available as a data source.