-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure all devices get 32-bit and 64-bit ABIs from the Play Store #951
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a6283ab
chore: update google-play-deploy bitrise build step
gmaclennan d05a320
fix: upload release apk with armeabi-v7a and arm64-v8a ABIs
gmaclennan 1ab5c14
fix: build apk for x86 ABIs and include in play store deployment
gmaclennan fca7864
fix: fix apk file rename
gmaclennan 49bcdb2
fix: fix intel build config
gmaclennan 187a4a3
fix: ensure intel apk has different version code
gmaclennan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,7 @@ workflows: | |
before_run: | ||
- primary | ||
envs: | ||
- GRADLE_TASKS: assembleApp assembleIccaRelease bundleAppUniversal -x assembleAppDebug | ||
- GRADLE_TASKS: assembleApp assembleIccaRelease assembleAppUniversal assembleAppIntel -x assembleAppDebug | ||
opts: | ||
is_expand: false | ||
steps: | ||
|
@@ -112,6 +112,7 @@ workflows: | |
# Uppercase flavor or remove | ||
filename="${filename/-qa-/-QA-}" | ||
filename="${filename/-icca-release/-ICCA}" | ||
filename="${filename/-app-intel/-x86}" | ||
filename="${filename/-app-release/}" | ||
filename="${filename/-app-/-}" | ||
# Construct path with new filename | ||
|
@@ -142,10 +143,12 @@ workflows: | |
RELEASE_APK_PATH=$(echo -n "${BITRISE_APK_PATH_LIST//|/$'\n'}" | grep mapeo-.*[0-9]\.apk) | ||
UNIVERSAL_APK_PATH=$(echo -n "${BITRISE_APK_PATH_LIST//|/$'\n'}" | grep mapeo-.*[0-9]-universal\.apk) | ||
ICCA_RELEASE_APK_PATH=$(echo -n "${BITRISE_APK_PATH_LIST//|/$'\n'}" | grep mapeo-.*ICCA\.apk) | ||
INTEL_RELEASE_APK_PATH=$(echo -n "${BITRISE_APK_PATH_LIST//|/$'\n'}" | grep mapeo-.*x86\.apk) | ||
|
||
envman add --key RELEASE_APK_PATH --value "$RELEASE_APK_PATH" | ||
envman add --key UNIVERSAL_APK_PATH --value "$UNIVERSAL_APK_PATH" | ||
envman add --key ICCA_RELEASE_APK_PATH --value "$ICCA_RELEASE_APK_PATH" | ||
envman add --key INTEL_RELEASE_APK_PATH --value "$INTEL_RELEASE_APK_PATH" | ||
- [email protected]: | ||
title: Upload APK for Arm | ||
inputs: | ||
|
@@ -200,12 +203,11 @@ workflows: | |
- files_to_upload: $RELEASE_APK_PATH | ||
- body: "See [changelog](https://github.com/digidem/mapeo-mobile/blob/develop/CHANGELOG.md) for a detailed list of changes" | ||
- api_token: $GITHUB_TOKEN | ||
- google-play-deploy@3.0.2: | ||
- google-play-deploy@3.7.2: | ||
inputs: | ||
- service_account_json_key_path: $BITRISEIO_SERVICE_ACCOUNT_JSON_KEY_URL | ||
- track: beta | ||
- apk_path: $RELEASE_APK_PATH | ||
- app_path: $BITRISE_AAB_PATH | ||
- app_path: $RELEASE_APK_PATH|$INTEL_RELEASE_APK_PATH | ||
- package_name: com.mapeo | ||
meta: | ||
bitrise.io: null | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so just to clarify, this is replacing the command that builds the aab with the commands to build the apks instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I define the tasks in the environment variable so that I can share the same build code for the different builds (internal, release candidate, and release). The naming of these is
${task}${flavor}${builtType}
. I removed thebundleAppUniversal
task which would create a.aab
of the "app" flavor and "universal" build type (the universal build type includes both arm and x86, 32- and 64-bit). I replaced it with theassembleAppUniversal
task which builds the same but as a.apk
. I also added a new built typeintel
which only includes the x86 binaries. When publishing multiple APKs to the Play Store they must not overlap (e.g. we could not publish therelease
build (which is only Arm) and theuniversal
build, because theuniversal
build includes Arm as well as x86.