chore: Patch nodejs-mobile to specify NDK version #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes failed builds if a later version of NDK is installed. nodejs-mobile was not specifying which NDK version to use, which caused it to use the latest installed version
|
Looks like the build on Github is passing e2e tests (the issue before with NDK v22 was it built without error, but then the builds failed - the issue with NDK v23 is that they have removed "GNU binutils" which nodejs-mobile seems to depend on to build modules. I have no real idea about what these are!) We should make a PR to
I can do it one day when I have free time. |
gmaclennan
added a commit
that referenced
this pull request
Nov 23, 2021
…ject-invite-server * commit '1aa1749aaf6e5a439234e9fedf7ff28d05cd0edb': chore: Add Husky to project (#755) chore: Fix small typo in translation description (#868) feat: Show alert after successfully importing config (#864) chore(release): Prepare release 5.3.2 fix: Add missing Portuguese and Spanish translations chore(release): Prepare release 5.3.1 fix: Do not surface Practice Mode in config details in settings (#852) fix: Enable navigation to Experiments screen (#853) fix: Do not surface Practice Mode in config details in settings (#852) fix: Enable navigation to Experiments screen (#853) feat: Add Create Project flow (#846) chore(deps): bump ansi-regex from 5.0.0 to 5.0.1 in /src/backend (#753) feature: Add new translation strings (en) (#754) chore: Patch nodejs-mobile to specify NDK version (#757) Update contributing docs for NDK fix chore(release): Prepare release 5.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failed builds if a later version of NDK is installed.
nodejs-mobile was not specifying which NDK version to use,
which caused it to use the latest installed version