Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map zoom-out when switching back to map screen #147

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Conversation

gmaclennan
Copy link
Member

@noffle reported this error, which happens when the map is not in "follow-mode" - e.g. when the map is not centered over the user location. If you switch away from the map screen and then return to it, it zooms out to zoom 8.

This fixes things, by keeping the MapCamera component mounted when the user navigates away from the map. It uses the navigation focus to turn off follow-mode when the user navigates away though, in order to reduce battery use. The map being in follow-mode and the display of the user location (blue dot) on the map has a significant impact on CPU/battery.

@gmaclennan gmaclennan merged commit 372c6fc into master Jun 20, 2019
@gmaclennan gmaclennan deleted the fix/map-zoom branch June 20, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant