feat: Add Create Project flow #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
commented
Oct 18, 2021
Comment on lines
+34
to
+52
| return ( | ||
| <View | ||
| style={[ | ||
| styles.flexContainer, | ||
| showPracticeModeUi && styles.practiceModeContainer, | ||
| ]} | ||
| > | ||
| <View style={styles.flexContainer}>{children}</View> | ||
|
|
||
| //If practice mode is NOT enabled, the user is just returned the children | ||
| return <React.Fragment>{children}</React.Fragment>; | ||
| {showPracticeModeUi && !hideBar && ( | ||
| <View style={styles.bottomBar}> | ||
| <MaterialCommunityIcons name="lightbulb-on" color={WHITE} size={28} /> | ||
| <Text style={styles.text}> | ||
| <FormattedMessage {...m.title} /> | ||
| </Text> | ||
| </View> | ||
| )} | ||
| </View> | ||
| ); |
There was a problem hiding this comment.
Instead of relying on conditional returns to hide practice mode UI, we conditionally style a wrapping container. This prevents massive re-renders with the relatively minor trade-off of keeping some practice mode nodes present
achou11
force-pushed
the
ac/841/create-project-flow
branch
3 times, most recently
from
67dc7d4 to
de7e86e
Compare
achou11
force-pushed
the
ac/841/create-project-flow
branch
from
de7e86e to
1eab98f
Compare
ErikSin
reviewed
Oct 19, 2021
Closed
gmaclennan
added a commit
that referenced
this pull request
Nov 23, 2021
…ject-invite-server * commit '1aa1749aaf6e5a439234e9fedf7ff28d05cd0edb': chore: Add Husky to project (#755) chore: Fix small typo in translation description (#868) feat: Show alert after successfully importing config (#864) chore(release): Prepare release 5.3.2 fix: Add missing Portuguese and Spanish translations chore(release): Prepare release 5.3.1 fix: Do not surface Practice Mode in config details in settings (#852) fix: Enable navigation to Experiments screen (#853) fix: Do not surface Practice Mode in config details in settings (#852) fix: Enable navigation to Experiments screen (#853) feat: Add Create Project flow (#846) chore(deps): bump ansi-regex from 5.0.0 to 5.0.1 in /src/backend (#753) feature: Add new translation strings (en) (#754) chore: Patch nodejs-mobile to specify NDK version (#757) Update contributing docs for NDK fix chore(release): Prepare release 5.3.0
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #841
Notes:
Preview: