feat: support more geometry types #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
EvanHahn
force-pushed
the
support-more-geometry-types
branch
from
64fed7d to
ed23b31
Compare
|
Hey @EvanHahn sorry for this stray comment on your PR, but wanted to note that for alerts, we'll need LineString and MultiLineString as well. With those included, you'll be covered for every possible geometry type. |
|
Thanks for this. I don't think CoMapeo Mobile currently supports these types, so I'll ask about that. |
EvanHahn
force-pushed
the
support-more-geometry-types
branch
from
ed23b31 to
006790a
Compare
|
Also requires some work to display them in CoMapeo Mobile. Issue here: digidem/comapeo-mobile#874 |
EvanHahn
added a commit
to digidem/comapeo-core
that referenced
this pull request
Dec 11, 2024
This is necessary for <digidem/comapeo-cloud#36>.
EvanHahn
added a commit
to digidem/comapeo-core
that referenced
this pull request
Dec 11, 2024
This is necessary for <digidem/comapeo-cloud#36>.
This was referenced Dec 12, 2024
Merged
EvanHahn
force-pushed
the
support-more-geometry-types
branch
from
006790a to
1847f93
Compare
luandro
pushed a commit
to digidem/comapeo-cloud-client
that referenced
this pull request
Jan 24, 2025
* feat: support more geometry types In addition to `Point`, we now support additional geometry objects. Closes [digidem#35]. [digidem#35]: digidem#35 * chore: Ensure all alert geometry types are tested * chore: remove console.log * chore: fix tsconfig for VSCode inline checking * fix: fix types in tests --------- Co-authored-by: Gregor MacLennan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on digidem/comapeo-core#980.
In addition to
Point, we now support additional geometries.Closes #35.