Upgrade afj #21
Merged
Upgrade afj #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdean-digicatapult
requested review from
jonmattgray and
n3op2
as code owners
mattdean-digicatapult
requested review from
dc-andysign and
dblane-digicatapult
|
btw these tests are really flakey and that issue has been raised i nthe upstream |
n3op2
previously approved these changes
Aug 2, 2023
dc-andysign
requested changes
Aug 2, 2023
dc-andysign
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is equivalent to openwallet-foundation/credo-ts-ext#222 from the upstream. Most of the comments from there apply equally here. Note I would try to avoid changing too much as the upstream PR is not yet approved and we will likely want to fix this up in line with that.