-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L3 231/add monitoring #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msterle
requested review from
mattdean-digicatapult,
jonmattgray,
n3op2 and
dblane-digicatapult
as code owners
April 5, 2024 16:55
dblane-digicatapult
requested changes
Apr 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, we should ensure that alice, bob, charlie and the nginx/infra sync depend on the monitoring sync kustomization being completed first as this introduces the CRDs that will subsequently be used in those kustomizations/helm charts.
dblane-digicatapult
requested changes
Apr 22, 2024
clusters/kind-cluster/monitoring/kube-state-metrics-config.yaml
Outdated
Show resolved
Hide resolved
dblane-digicatapult
previously approved these changes
Apr 22, 2024
Co-authored-by: David Blane <[email protected]>
dblane-digicatapult
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 1/2 for L3-231
This PR adds monitoring to the king cluster, production cluster addressed in a follow-up PR
Notes:
kube-state-metrics
chart. This bug has been resolved, but the fix has not been pulled intokube-prometheus-stack
yet