Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename doc files and fix typos #246

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

yucongalicechen
Copy link
Contributor

closes #238
@bobleesj I can have some feedback before @sbillinge reviews it

@@ -13,27 +13,27 @@ This example will demonstrate how to use the functions in the
to convert it to ``2theta`` or ``d``. ::

# Example: convert q to 2theta
from diffpy.utils.transformers import q_to_tth
from diffpy.utils.transforms import q_to_tth
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix typo

Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (112d0a1) to head (c982502).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          380       380           
=========================================
  Hits           380       380           

@bobleesj
Copy link
Contributor

closes #238

@bobleesj I can have some feedback before @sbillinge reviews it

Have you rendered the docs locally to check all links are populated and no broken links?

@yucongalicechen
Copy link
Contributor Author

closes #238
@bobleesj I can have some feedback before @sbillinge reviews it

Have you rendered the docs locally to check all links are populated and no broken links?

Yep, I just built them locally and every link works. Here's a screenshot:
1

@yucongalicechen
Copy link
Contributor Author

The transforms example was displayed improperly. I edited it and it's working now.

2
3

@yucongalicechen
Copy link
Contributor Author

@bobleesj in the docstring the XQUANTITIES is not showing. Shall I open a new issue or just comment on #239?

4
5

@bobleesj
Copy link
Contributor

@bobleesj in the docstring the XQUANTITIES is not showing. Shall I open a new issue or just comment on #239?

yes please open the issue!

@bobleesj
Copy link
Contributor

Lovely, looks good to me


# Example: convert d to q
from diffpy.utils.transformers import tth_to_q
from diffpy.utils.transforms import d_to_q
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@yucongalicechen
Copy link
Contributor Author

thanks @bobleesj ! @sbillinge ready to review now!

@sbillinge
Copy link
Contributor

@bobleesj in the docstring the XQUANTITIES is not showing. Shall I open a new issue or just comment on #239?

yes please open the issue!

This may not fix. We will have to see. It depends if that unpack can be made to be done dynamically during the doc builds or not. If it doesn't fix it is honestly OK to have it like this in the API docs which are generally "developer-facing" and not "user-facing" and I would expect a developer to be able to figure out what is going on

@sbillinge sbillinge merged commit 2ccd7d6 into diffpy:main Dec 18, 2024
4 of 5 checks passed
@yucongalicechen yucongalicechen deleted the rename branch December 18, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use lowercase_with_underscore.rst naming convention for doc files
3 participants