Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest-cov test.txt dependency list #108

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Sep 17, 2024

We shall use pytest-cov instead of using coverage to run pytest. The previous codecov 0% error occurred because the tests folder has been moved to the top directory level and coverage isn't able to import diffpy. due to the namespace.

So the GH actions can be modified

from:

        run: |
          coverage run -m pytest -vv -s
          coverage report -m
          codecov

to:

        run: |
          pytest --cov
          coverage report -m
          codecov

Reference:

Copy link

Warning! No news item is found for this PR. If this is an user facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

@bobleesj bobleesj marked this pull request as ready for review September 17, 2024 13:20
@sbillinge sbillinge merged commit d4133d8 into diffpy:main Sep 17, 2024
2 of 3 checks passed
@sbillinge
Copy link
Contributor

Thanks for the detailed explanation

@bobleesj bobleesj deleted the patch-1 branch September 17, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants