Cookiecutter - move tests folder, add entry point, conduct functional tests #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
changed the title
bobleesj
commented
Nov 1, 2024
There was a problem hiding this comment.
@sbillinge ready for review - now I have a better understanding of matrix decomposition
bobleesj
commented
Nov 1, 2024
| @@ -35,9 +35,16 @@ | |||
| .. |Tracking| image:: https://img.shields.io/badge/issue_tracking-github-blue | |||
| :target: https://github.com/diffpy/diffpy.nmf_mapping/issues | |||
|
|
|||
| Run NMF analysis on PDF and XRD data | |||
| Python package for running NMF analysis on PDF and XRD data. | |||
There was a problem hiding this comment.
I copied the longer description but I think we can refine it. Will address in a separate PR.
|
@sbillinge Ready for review - applied pre-commit |
|
Just to note, no default behavior has been added but we can merge to a different branch that is not main? Wasn't sure how the cloud server uses the source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
Closes #22
Closes #15
Will add news after cookiecutting. Next, I need to do the API workflow.
Will resolve tests