-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: cookiecutter and pre-commit formatting updates #77
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 4 4
Lines 177 177
=======================================
Hits 166 166
Misses 11 11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comments. For copyright statements, give them the correct range as best as you can figure it out. Code written by Sani was with when he was here which was around when he published his paper (a bit before)
Please see new way of handling news to her everything passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could of small things. Also, a bunch of the copyrights seen to have disappeared. Please check any file you edited is updated to <original date> - 2025
@bobleesj Can we add functionality to better handle copyright in When we run scikit, we could add a user input response that says "Year of first release:". If its before the current year, then the copyright would update with a hyphen (ie. Copyright 2022-2025). If its a new package or was published within the current year, that could be the default response (ie. Copyright 2025). We would have to be thoughtful not to have unnecessary hyphens, but I think this would streamline things a bit. Thoughts? |
Okay, the copyrights should be good now. Let me know if things look off on your end. |
Maybe. But I dont see a big benefit because one could simply run git diff and run git restore . This doesn't require that many files to review and we want users to do this actuall. Second, some packages and within ours have likely have different license formats and we dont want to force non diffpy users to enter this year info |
Yes, this is correct. It is only relevant for the On the other hand, if we are using a standard file header in our |
Also updated copyright from 2024 to 2025. Did not add a news item because code functionality does not change.