Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build GitHub pages with write permissions - deploy via worfklow dispatch and on publish #68

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

bobleesj
Copy link
Contributor

We want to build docs when published (GitHub release) or by workflow dispatch.

Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

workflow_dispatch:

jobs:
docs:
uses: Billingegroup/release-scripts/.github/workflows/_publish-docs-on-release.yml@v0
permissions:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this write-permission, I previously had

   15 files changed, 78 insertions(+), 107 deletions(-)
Push the commit or tag
  /usr/bin/git push origin gh-pages
  remote: Permission to bobleesj-test-org/bobleesj.release.git denied to github-actions[bot].


on:
release:
types:
- published
types: [published]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (402e7d5) to head (b65ad58).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           4        4           
  Lines         177      177           
=======================================
  Hits          166      166           
  Misses         11       11           

@bobleesj
Copy link
Contributor Author

Ready for review @sbillinge. This will fix the current issue of not displaying the latest changelog. Ref Billingegroup/release-scripts#94

Once you've merged this, could you please run this Deploy Documentation on Release workflow via dispatch? We should then see the latest v0.2.0 news under here https://www.diffpy.org/diffpy.fourigui/release.html

@bobleesj
Copy link
Contributor Author

@cadenmyers13 cc'ing Caden here. Since Andrew's PR has been merged #67, let's also check whether the API section builds.

@bobleesj bobleesj changed the title Build GitHub pages by addition write permissions Build GitHub pages with write permissions - deploy via worfklow dispatch and on publish Nov 13, 2024
@sbillinge sbillinge merged commit 5a437f2 into diffpy:main Nov 13, 2024
4 of 5 checks passed
@sbillinge
Copy link
Contributor

Deploy docs workflow ran successfully on dispatch

@sbillinge
Copy link
Contributor

Changeling appears in the docs now but still no API documentation building?

@bobleesj bobleesj deleted the patch-3 branch November 13, 2024 14:22
@bobleesj
Copy link
Contributor Author

bobleesj commented Nov 13, 2024

Deploy docs workflow ran successfully on dispatch
awesome!

@cadenmyers13 could you please check with Andrew why Api doc isn't rendering ?

https://github.com/Billingegroup/release-scripts/blob/v0/.github/workflows/_publish-docs-on-release.yml

This is the script that @sbillinge used to re-render the doc - displaying the latest changelog 0.2.0 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants