Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for JDBI bind list params. #955

Merged
merged 3 commits into from
Oct 2, 2021
Merged

Add support for JDBI bind list params. #955

merged 3 commits into from
Oct 2, 2021

Conversation

dylanbaroody
Copy link
Contributor

JDBI bind list params are in the format: IN(<ids>). Previously the formatter would break these up:

IN(
  < ids >
)

Which breaks the JDBI integration. This will no longer happen in the case that there is a < then a NAME type token then >

@dylanbaroody
jdbi_list_param Add support for JDBI bind list params.
704e6ce 
JDBI bind list params are in the format: `IN(<ids>)`. Previously the formatter would break these up:

```
IN(
  < ids >
)
```

Which breaks the JDBI integration. This will no longer happen in the case that there is a `<` then a NAME type token then `>`
@dylanbaroody dylanbaroody changed the title jdbi_list_param Add support for JDBI bind list params. Add support for JDBI bind list params. Oct 1, 2021
@nedtwigg
Copy link
Member

nedtwigg commented Oct 1, 2021 •
edited
Loading

Run spotlessApply to fix CI and this is good :)

@nedtwigg nedtwigg merged commit 49b3363 into diffplug:main Oct 2, 2021
@nedtwigg nedtwigg mentioned this pull request Oct 2, 2021
Closed
@nedtwigg
Copy link
Member

nedtwigg commented Oct 2, 2021

Published in plugin-gradle 5.16.0 and plugin-maven 2.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanbaroody @nedtwigg