Code

Any exception should break the build#72

Code

Merged

nedtwigg merged 12 commits intodiffplug:masterdiffplug/spotless:masterfrom nedtwigg:feature/strictExceptionsnedtwigg/spotless:feature/strictExceptionsCopy head branch name to clipboardJan 20, 2017

+481-158

Commits

Commits on Jan 16, 2017

• Renamed ThrowingEx.unwrapAsRuntimeOrRethrow to unwrapCause.

  Show description for f692864
  nedtwigg

  committed
  f692864

  Copy full SHA for f692864

• Added a FormatExceptionPolicy so that Formatter can become more strict about exceptions in its formatters. Default behavior matches the existing behavior.

  nedtwigg

  committed
  1b8483e

  Copy full SHA for 1b8483e

• FormatExceptionPolicy implementations need to implement Serializable and equals/hashCode with the same constraints as SerializableFileFilter. Refactored the toBytes() method into the interface `N…

  Show description for e36ddab
  nedtwigg

  committed
  e36ddab

  Copy full SHA for e36ddab

• LineEnding.Policy is now marked with NoLambda, which exposed equality issues we had in the non-GIT_ATTRIBUTES policies. Since GitAttributesLineEndings.Policy uses LazyForwardingEquality, it require…

  Show description for 56aa1b9
  nedtwigg

  committed
  56aa1b9

  Copy full SHA for 56aa1b9

Commits on Jan 18, 2017

• Formatter now implements Serializable in addition to equals() and hashCode(), which required some serialization tricks because Charset and Path are not serializable.

  nedtwigg

  committed
  241033c

  Copy full SHA for 241033c

• StepEqualityTester.API had three methods, but really only needed one. Refactored to only have one.

  nedtwigg

  committed
  d126ed5

  Copy full SHA for d126ed5

• StepEqualityTester now tests that equality is preserved across serialization. Turns out that it wasn't for FreshMarkStep, which has now been fixed.

  nedtwigg

  committed
  7ed828c

  Copy full SHA for 7ed828c

• Renamed StepEqualityTester to SerializableEqualityTester, now that we're using it for any serializable object.

  nedtwigg

  committed
  5f5efed

  Copy full SHA for 5f5efed

• Added a strict FormatExceptionPolicy.

  nedtwigg

  committed
  b47b12d

  Copy full SHA for b47b12d

• FormatExtension now has methods ignoreErrorForStep and ignoreErrorForPath, but by default any exceptions will kill the build.

  nedtwigg

  committed
  672051d

  Copy full SHA for 672051d

• FormatExceptionPolicy now takes (String relativePath) rather than (File file, Path rootDir).

  nedtwigg

  committed
  e279153

  Copy full SHA for e279153

Commits on Jan 20, 2017

• Merge branch 'master' into feature/strictExceptions

  nedtwigg

  authored
  7e88858

  Copy full SHA for 7e88858