Fix crashing on empty #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedtwigg
requested changes
Oct 16, 2019
There was a problem hiding this comment.
Thanks! Your fix does a good job at the site of the stacktrace, but it seems easier to just say at the beginning of the function if (input.isEmpty()) { return input; }. That way all the code below that can take as a precondition "this string has length > 0". That's more robust than having to check for it at every point.
Also, update your changelog entry so that it points to this PR.
Thanks for the PR!
|
Thanks again! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305
ImportSorter no longer blows up if you give it an empty file.