Add Sort Members functionality to Eclipse formatter #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super cool, thanks! Needs
|
|
Problem now seems to be
|
…embers functionality
|
@nedtwigg I addressed all the points and I think it is ready for review. Any feedback is very appreciated. |
|
This was hard to do, thanks for the PR! Will be released soon... |
|
@nedtwigg do you have an ETA for release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We not only want to format our code with Eclipse JDT, but also sort the members as we know it from Eclipse IDE. This ensures that the methods are always in sorted order and thus may help for better readability. It is turned off by default, but you might want to consider enabling it when setting coding standards for a project. There are two options to enable/disable it on project level or on file level.