Code

obsolete - Add support for linters#1097

Code

Closed

nedtwigg wants to merge 31 commits intofeat/cleanup-breaking-changesdiffplug/spotless:feat/cleanup-breaking-changesfrom feat/lintdiffplug/spotless:feat/lintCopy head branch name to clipboard

+1,308-752

Commits

Commits on Jan 14, 2022

• Define a Lint.

  nedtwigg

  committed
  d5b0421

• Add a lint method to FormatterStep and let it wripple through.

  nedtwigg

  committed
  db676fc

• Make Lint roundtrippable through a String.

  nedtwigg

  committed
  5dc6271

• Formatter.lint

  nedtwigg

  committed
  cc71751

• Lint ripples through DirtyState and Formatter.

  nedtwigg

  committed
  aac3972

• SpotlessTaskImpl now generates both a formatted result and a lint result.

  nedtwigg

  committed
  a25eded

• SpotlessTaskImpl now generates a lint result for check and for apply (the line numbers in a lint will change depending on whether the apply already ran or not).

  nedtwigg

  committed
  89339cd

• Gradle spotlessCheck will now throw an error if all of the files are as formatted as they can be, except for lints.

  nedtwigg

  committed
  cac4f70

• Maven spotless:check will now throw an error if all of the files are as formatted as they can be, except for lints.

  nedtwigg

  committed
  d4ec76b

• Default FormatterFunc.lint now traps errors from the formatter itself, and tries to parse a line number from the error message.

  nedtwigg

  committed
  7a1e72a

• Remove FormatExceptionPolicy.

  nedtwigg

  committed
  109c7fb

• Remove FormatExceptionPolicy from the maven plugin.

  nedtwigg

  committed
  0049661

• Replace FormatExceptionPolicy with LintPolicy inside the Gradle plugin.

  nedtwigg

  committed
  dd5165f

• Lint.toFile might need to create parent directories.

  nedtwigg

  committed
  85fbe71

• Lints are now quietly suppressed during apply, you have to do check to see them.

  nedtwigg

  committed
  e8e5df5

• Fix spotbugs warnings.

  nedtwigg

  committed
  6ec06cc

• Fix the bug I made from fixing spotbugs :)

  nedtwigg

  committed
  9557c66

• Make sure that FormatterFunc.Closeable's helpers support linting.

  nedtwigg

  committed
  2844068

• Fix FormatterFunc.Closeable earlier

  nedtwigg

  committed
  9134d8c

• Refactor PipeStepPair so that it can detect lost tags within our new lint paradigm. The old way made it impossible to detect lost tags if apply always succeeds.

  nedtwigg

  committed
  5a9799d

• Rename PipeStepPair to FenceStep.

  nedtwigg

  committed
  07b39cb

• Removed rootDir property Formatter and its builder because it was only used to annnotate errors, which is now done by the lint phase.

  nedtwigg

  committed
  78ddcd6

• DiffMessageFormatter.Builder::formatter needs a new Path rootDir parameter.

  nedtwigg

  committed
  f947c7b

Commits on Jan 15, 2022

• Adapt StepHarness for the new "exceptions never get thrown" environment.

  nedtwigg

  committed
  a3eef1f

• When a step throws an exception, we now accurately consider the entire file as linted, rather than just the first line.

  nedtwigg

  committed
  3f72b7e

• Fix tests.

  nedtwigg

  committed
  1ed3149

• Fix spotbugs.

  nedtwigg

  committed
  6e38887

• Fix wrong SuppressFBWarnings import.

  nedtwigg

  committed
  eb0feed

• Fix tests on windows.

  nedtwigg

  committed
  248ec28

• Fix prettier error test.

  nedtwigg

  committed
  3aa780e

• Make our testing parallel.

  nedtwigg

  committed
  e110426