-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in gradle plugin 6.21 to 6.22 (spotlessGroovyGradle fails with Missing required bundle org.eclipse.jdt.debug) #1860
Comments
remaining stacktrace:
|
Looks like an error related to the greclipse update from |
Okay I've had a dig into this, and I think it may be something to do with the file name it's looking for having a space in the error message, but a Filename from error message that it's trying to read:
Filename in that same directory that actually exists:
From stepping through in the debugger I think this may be a bug in Solstice rather than spotless itself. In SolsticeManfiest, this decode is done which looses the However later on it tries to read it here using that decoded URL in ShimBundle https://github.com/equodev/equo-ide/blob/8469bf809c24dd7a4d41e7fd743e3df90f0ec07e/solstice/src/main/java/dev/equo/solstice/ShimBundle.java#L262 which now doesn't have the correct filename and so can't find the file. I'm not particularly familiar with this code and it's been a while since I last contributed to spotless so I might be off the mark, but hopefully @nedtwigg will have some thoughts! |
…v6.21.0 Stay on 6.21.0 due to diffplug/spotless#1860
Stay on greclipse 4.27 due to diffplug/spotless#1860
Fantastic debugging @goughy000, that's very tricky to find. But once found, it was easy to fix in Solstice (see PR above). Fixes for this are shipping later tonight. |
Fixed in |
Thanks @nedtwigg - just had chance to try out 6.23.3 and it's not throwing anymore. Thanks for the fix! 🚀 |
If you are submitting a bug, please include the following:
❯ ./gradlew spotlessGroovyGradle
fails withMissing required bundle org.eclipse.jdt.debug needed by [org.eclipse.jdt.launching]
gradlew spotless[Apply/Check] --stacktrace
The text was updated successfully, but these errors were encountered: