Append feature for p2AsMaven #44
Conversation
https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fguide%2Fp2_repositorytasks.htm Append to a repository that is already there. (Default is "true")
| @@ -68,7 +68,6 @@ public void run() throws Exception { | |||
| project.getLogger().lifecycle("p2AsMaven " + def.group + " is dirty."); | |||
| } | |||
| // else, we'll need to run our own little thing | |||
| FileMisc.cleanDir(dirP2()); | |||
| FileMisc.cleanDir(dirP2Runnable()); | |||
There was a problem hiding this comment.
Should this be guarded on append? Otherwise this looks great and ready to merge to me!
|
I am only aware of the native p2.mirror append feature. Do you know wether Repo2Runnable is appendable? It could end in a corrupt repo db but i did not verify this. The maven install perhaps can handle it. With just keeping the original p2 dir we can guarantee a consistent state in all three directories. |
|
The guard around clean of p2dir is not needed. p2.mirror clears it automatically if append = false |
|
There's nothing in the docs for repo2runnable that mentions appendable. MavenInstall could be made to handle appendable without much trouble. My experience is that the vast majority of the time is spent in the p2 mirroring, so I don't think it's worth spending much effort on the much faster repo2runnable and mavenInstall phases. And it can always be done later :) If it looks good to you, I'll merge this now. Oxygen.2 releases tomorrow, so I'll add support for that then cut a new release of Goomph which includes your improvement here and Oxygen.2. |
|
the only thing is every clean existing p2AsMaven mirror will be "dirty" the first time one gets the new version because of the implemented token mechanism. this was needed to keep the default behavior append=false. |
|
Gotcha. Gradle forces everything to run again when the plugin classpath changes anyway, so I think that's alright. |
|
Released in |
this is the pr for #43