Re-enable num-traits
under an optional feature
#7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andrew!
First of all thanks a lot for developing this crate, I've been able to move some more of our data analysis pipeline to Rust thanks to it.
While I can understand why you want to get rid of the
num-traits
dependency in your context (at least, from what I got from the commit message of f19d626), it's actually super practical to have it available because you can depend on custom float types, the most interesting one for me beingf16
from thehalf
crate to work with a reduced memory footprint. The drop ofnum-traits
support prevented me from updating tov0.3
.This PR keeps the best of both worlds by hiding the
num-traits
dependency behind a feature gate, which is disabled by default. Users like me who want to use theFloat
trait fromnum-traits
can enable the feature, but by defaultkodama
remains without dependency.