Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop requirement from ~> 0.90.0 to ~> 0.91.1 #23

Closed
wants to merge 1 commit into from
Closed

Update rubocop requirement from ~> 0.90.0 to ~> 0.91.1 #23

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 24, 2020

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 0.91.1

Bug fixes

  • #8720: Fix an error for Lint/IdentityComparison when calling object_id method without receiver in LHS or RHS. (@koic)
  • #8767: Fix a false positive for Style/RedundantReturn when a rescue has an else clause. (@fatkodima)
  • #8710: Fix a false positive for Layout/RescueEnsureAlignment when Layout/BeginEndAlignment cop is not enabled status. (@koic)
  • #8726: Fix a false positive for Naming/VariableNumber when naming multibyte character variable name. (@koic)
  • #8730: Fix an error for Lint/UselessTimes when there is a blank line in the method definition. (@koic)
  • #8740: Fix a false positive for Style/HashAsLastArrayItem when the hash is in an implicit array. (@dvandersluis)
  • #8739: Fix an error for Lint/UselessTimes when using empty block argument. (@koic)
  • #8742: Fix some assignment counts for Metrics/AbcSize. (@marcandre)
  • #8750: Fix an incorrect auto-correct for Style/MultilineWhenThen when line break for multiple condidate values of when statement. (@koic)
  • #8754: Fix an error for Style/RandomWithOffset when using a range with non-integer bounds. (@eugeneius)
  • #8756: Fix an infinite loop error for Layout/EmptyLinesAroundAccessModifier with Layout/EmptyLinesAroundBlockBody when using access modifier with block argument. (@koic)
  • #8372: Fix Lint/RedundantCopEnableDirective autocorrection to not leave orphaned empty # rubocop:enable comments. (@dvandersluis)
  • #8372: Fix Lint/RedundantCopDisableDirective autocorrection. (@dvandersluis)
  • #8764: Fix Layout/CaseIndentation not showing the cop name in output messages. (@dvandersluis)
  • #8771: Fix an error for Style/OneLineConditional when using if-then-elsif-then-end. (@koic)
  • #8576: Fix Style/IfUnlessModifier to ignore cop disable comment directives when considering conversion to the modifier form. (@dsavochkin)

Changes

  • #8489: Exclude method respond_to_missing? from OptionalBooleanParameter cop. (@em-gazelle)
  • #7914: Style/SafeNavigation marked as having unsafe auto-correction. (@marcandre)
  • #8749: Disable Style/IpAddresses by default in Gemfile and gemspec files. (@dvandersluis)
Changelog

Sourced from rubocop's changelog.

0.91.1 (2020-09-23)

Bug fixes

  • #8720: Fix an error for Lint/IdentityComparison when calling object_id method without receiver in LHS or RHS. ([@koic][])
  • #8767: Fix a false positive for Style/RedundantReturn when a rescue has an else clause. ([@fatkodima][])
  • #8710: Fix a false positive for Layout/RescueEnsureAlignment when Layout/BeginEndAlignment cop is not enabled status. ([@koic][])
  • #8726: Fix a false positive for Naming/VariableNumber when naming multibyte character variable name. ([@koic][])
  • #8730: Fix an error for Lint/UselessTimes when there is a blank line in the method definition. ([@koic][])
  • #8740: Fix a false positive for Style/HashAsLastArrayItem when the hash is in an implicit array. ([@dvandersluis][])
  • #8739: Fix an error for Lint/UselessTimes when using empty block argument. ([@koic][])
  • #8742: Fix some assignment counts for Metrics/AbcSize. ([@marcandre][])
  • #8750: Fix an incorrect auto-correct for Style/MultilineWhenThen when line break for multiple condidate values of when statement. ([@koic][])
  • #8754: Fix an error for Style/RandomWithOffset when using a range with non-integer bounds. ([@eugeneius][])
  • #8756: Fix an infinite loop error for Layout/EmptyLinesAroundAccessModifier with Layout/EmptyLinesAroundBlockBody when using access modifier with block argument. ([@koic][])
  • #8372: Fix Lint/RedundantCopEnableDirective autocorrection to not leave orphaned empty # rubocop:enable comments. ([@dvandersluis][])
  • #8372: Fix Lint/RedundantCopDisableDirective autocorrection. ([@dvandersluis][])
  • #8764: Fix Layout/CaseIndentation not showing the cop name in output messages. ([@dvandersluis][])
  • #8771: Fix an error for Style/OneLineConditional when using if-then-elsif-then-end. ([@koic][])
  • #8576: Fix Style/IfUnlessModifier to ignore cop disable comment directives when considering conversion to the modifier form. ([@dsavochkin][])

Changes

  • #8489: Exclude method respond_to_missing? from OptionalBooleanParameter cop. ([@em-gazelle][])
  • #7914: Style/SafeNavigation marked as having unsafe auto-correction. ([@marcandre][])
  • #8749: Disable Style/IpAddresses by default in Gemfile and gemspec files. ([@dvandersluis][])

0.91.0 (2020-09-15)

New features

  • New option --cache-root and support for the RUBOCOP_CACHE_ROOT environment variable. Both can be used to override the AllCops: CacheRootDirectory config, especially in a CI setting. ([@sascha-wolf][])
  • #8582: Add new Layout/BeginEndAlignment cop. ([@koic][])
  • #8699: Add new Lint/IdentityComparison cop. ([@koic][])
  • Add new Lint/UselessTimes cop. ([@dvandersluis][])
  • #8707: Add new Lint/ConstantDefinitionInBlock cop. ([@eugeneius][])

Bug fixes

  • #8627: Fix a false positive for Lint/DuplicateRequire when same feature argument but different require method. ([@koic][])
  • #8674: Fix an error for Layout/EmptyLineAfterMultilineCondition when conditional is at the top level. ([@fatkodima][])
  • #8658: Fix a false positive for Style/RedundantSelfAssignment when calling coercion methods. ([@fatkodima][])
  • #8669: Fix an offense creation for Lint/EmptyFile. ([@fatkodima][])
  • #8607: Fix a false positive for Lint/UnreachableLoop when conditional branch includes continue statement preceding break statement. ([@fatkodima][])
  • #8572: Fix a false positive for Style/RedundantParentheses when parentheses are used like method argument parentheses. ([@koic][])
  • #8630: Fix some false positives for Style/HashTransformKeys and Style/HashTransformValues when the receiver is an array. ([@eugeneius][])
  • #8653: Fix a false positive for Layout/DefEndAlignment when using refinements and private def. ([@koic][])
  • #8655: Fix a false positive for Style/ClassAndModuleChildren when using cbase class name. ([@koic][])
  • #8654: Fix a false positive for Style/SafeNavigation when checking foo&.empty? in a conditional. ([@koic][])
  • #8660: Fix a false positive for Style/ClassAndModuleChildren when using cbase module name. ([@koic][])

... (truncated)

Commits
  • de054ee Cut 0.91.1
  • c21be8f [Fix #8372] Fix Lint/RedundantCopEnableDirective autocorrection not removin...
  • b59c48a [Fix #8372] Fix Lint/RedundantCopDisableDirective autocorrection removing a...
  • 39f0624 Move a changelog entry
  • 54c63cf [Fix #8576] Fix Style/IfUnlessModifier to ignore cop disable comment direct...
  • 3ec3e38 Tweak a couple of changelog entries
  • 5cc162e [Fix #8771] Fix an error for Style/OneLineConditional
  • faaa683 Merge pull request #8769 from koic/use_cop_base_api_for_several_style_cops
  • c70badc Merge pull request #8768 from fatkodima/redundant_return-rescue-else
  • fd6d273 Use Cop::Base API for some Style cops
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 24, 2020
@dependabot dependabot bot mentioned this pull request Sep 24, 2020
Closed
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 28, 2020

Superseded by #24.

@dependabot dependabot bot closed this Sep 28, 2020
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-tw-0.91.1 branch September 28, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants