Minor rustdoc improvements #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The long sentence in statement_cache/mod.rs felt hard to read. I broke it up in two. - s/a unbound/an unbound/ - I was about to write my own equivalent to BoxedSqlQuery when I found it mentioned in a Github issue. So I thought into_boxed() deserves more advertisement.
weiznich
approved these changes
Jan 31, 2025
|
I'm sorry for the unwanted edits. This is very embarrassing. - Thank you for cleaning up after me. |
JohnTitor
reviewed
Feb 2, 2025
diesel/src/pg/connection/raw.rs
Outdated
| #![allow(unsafe_code)] // ffi code | ||
| #![allow(unsafe_code)] // ffi Code |
There was a problem hiding this comment.
I don't think this diff makes a difference.
No worries, after all that's one of my tasks as maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long sentence in statement_cache/mod.rs felt hard to read. I broke it up in two.
s/a unbound/an unbound/
I was about to write my own equivalent to BoxedSqlQuery when I found it mentioned in a Github issue. So I thought into_boxed() deserves more advertisement.