Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup for #3213 #3236

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Minor cleanup for #3213 #3236

merged 2 commits into from
Jul 18, 2022

Conversation

weiznich
Copy link
Member

  • Improve the row by row iterator implementation
  • Minor documentation simplification

@weiznich
Minor cleanup for diesel-rs#3213
db7a3e6 
* Improve the row by row iterator implementation
* Minor documentation simplification
@weiznich weiznich requested a review from Ten0 July 18, 2022 14:16
Ten0
Ten0 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@Ten0 Ten0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I would also add c583953 to this PR.

@Ten0 @weiznich
Pass single pointer to update_transaction_manager_status' non_generic…
999ab8d 
…_inner

Reduces amount of generated LLVM code per query
@weiznich weiznich merged commit 6cf2ac7 into diesel-rs:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ten0 Ten0 Ten0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiznich @Ten0