Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3151 #3155

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Fix #3151 #3155

merged 1 commit into from
Apr 29, 2022

Conversation

weiznich
Copy link
Member

Allow ORDER BY clauses to be used in any combination subquery by
either put parenthesis around the subqueries (Postgres/Mysql) or adding
a wrapping subquery (Sqlite).

Allow `ORDER BY` clauses to be used in any combination subquery by
either put parenthesis around the subqueries (Postgres/Mysql) or adding
a wrapping subquery (Sqlite).
@weiznich weiznich requested a review from a team April 29, 2022 17:12
Copy link
Contributor

@chusteven chusteven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; code is generic enough to only necessitate a few lines of changes 👍

@weiznich weiznich merged commit ece7bc2 into diesel-rs:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants