-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ungate try_from because it has been stabilized #2010
Changes from 6 commits
b0e0453
5966e3e
47e74f3
0db7c6b
b6cecbd
0b96ab4
59f110e
9641aef
0892d84
d2dafbb
6cc7c2c
1cc4a03
82974ee
1438a71
1825bcd
e4bdb2e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,7 +93,7 @@ | |
//! You can come ask for help at | ||
//! [gitter.im/diesel-rs/diesel](https://gitter.im/diesel-rs/diesel) | ||
|
||
#![cfg_attr(feature = "unstable", feature(specialization, try_from))] | ||
#![cfg_attr(feature = "unstable", feature(specialization))] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should remove the gating on the uses of this feature as well (grep There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. try_from has been stabilized (ungated) at nightly but it is still nightly only API. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah I see There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you update the FIXME comment to specify which Rust version we can use it? |
||
// Built-in Lints | ||
#![deny( | ||
warnings, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
nightly-2018-11-27 | ||
nightly-2019-02-26 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That changes the output of our compile tests, which means you need to go though that errors and adjust them. (There is a script for that) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated nightly version to pass test. Is this acceptable? To say more, what's the policy of supported nightly version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's fine. This is only the compile tests. We don't officially support nightly, we just bump this periodically as needed to be able to run the compile tests (which require nightly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see.