Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clean HTTP 1.1 to 2 upgrade headers #517

Merged
merged 2 commits into from
Dec 3, 2024
Merged

feat: clean HTTP 1.1 to 2 upgrade headers #517

merged 2 commits into from
Dec 3, 2024

Conversation

NiccoMlt
Copy link
Contributor

@NiccoMlt NiccoMlt commented Dec 2, 2024

  • always drop HTTP2-Settings header
  • drop Connection and Upgrade header only if the upgrade is to HTTP/2

@NiccoMlt
Squashed commit of the following:
347f75c 
commit a10a07a
Author: Niccolò Maltoni <[email protected]>
Date:   Sun Dec 1 23:49:22 2024 +0100

    test: fixing UnreachableBackendTest

commit 5f995b2
Author: Niccolò Maltoni <[email protected]>
Date:   Sun Dec 1 23:47:27 2024 +0100

    test: fix MaintenanceModeTest

commit 75cfd27
Author: Niccolò Maltoni <[email protected]>
Date:   Sun Dec 1 17:44:23 2024 +0100

    test: fix ManagersExecutionTest and StuckRequestsTest

commit e0633ba
Author: Niccolò Maltoni <[email protected]>
Date:   Fri Nov 29 18:24:37 2024 +0100

    refactor: cleanup tests

commit d270508
Author: Niccolò Maltoni <[email protected]>
Date:   Thu Nov 21 15:44:31 2024 +0100

    feat: invert HttpProxyServer dependency for mapper

    � Conflicts:
    �	carapace-server/src/test/java/org/carapaceproxy/listeners/ListenerConfigurationTest.java

commit 7e348bb
Author: Niccolò Maltoni <[email protected]>
Date:   Thu Nov 21 15:08:02 2024 +0100

    feat: introduce SafeBackendSelector

commit 48b5bf3
Author: Niccolò Maltoni <[email protected]>
Date:   Mon Nov 11 15:45:01 2024 +0100

    chore: cleanup todo comments

commit 2e08342
Author: Niccolò Maltoni <[email protected]>
Date:   Thu Nov 21 11:55:04 2024 +0100

    feat: add new configurations

    * add `healthmanager.warmupperiod` configuration (default 30s)
    * add `backend.<id>.coldcapacity` configuration (default 10)
    * add tolerance configuration

commit 7c4768c
Author: Niccolò Maltoni <[email protected]>
Date:   Thu Nov 21 13:03:33 2024 +0100

    feat: implement the feature by spreading the backend status

commit dc6f8bd
Author: Niccolò Maltoni <[email protected]>
Date:   Wed Nov 27 17:39:45 2024 +0100

    feat: introduce status tracking to BackendHealth* entities

    feat: introduce status tracking to BackendHealth* entities

    feat: introduce status tracking to BackendHealth* entities

    � Conflicts:
    �	carapace-server/src/main/java/org/carapaceproxy/server/backends/BackendHealthStatus.java

commit 9a2026c
Author: Niccolò Maltoni <[email protected]>
Date:   Wed Nov 27 17:39:14 2024 +0100

    refactor: cleanup tests

    � Conflicts:
    �	carapace-server/src/test/java/org/carapaceproxy/DatabaseConfigurationTest.java
    �	carapace-server/src/test/java/org/carapaceproxy/RawClientTest.java

commit 1c17c7d
Author: Niccolò Maltoni <[email protected]>
Date:   Wed Nov 27 17:26:09 2024 +0100

    build: fix InaccessibleObjectException

    � Conflicts:
    �	pom.xml

    � Conflicts:
    �	pom.xml

commit 4b6eefc
Author: Niccolò Maltoni <[email protected]>
Date:   Wed Nov 27 17:24:18 2024 +0100

    refactor: recordize BackendHealthCheck

    � Conflicts:
    �	carapace-server/src/main/java/org/carapaceproxy/server/backends/BackendHealthManager.java
    �	carapace-server/src/main/java/org/carapaceproxy/server/backends/BackendHealthStatus.java

    � Conflicts:
    �	carapace-server/src/main/java/org/carapaceproxy/server/backends/BackendHealthManager.java
    �	carapace-server/src/main/java/org/carapaceproxy/server/backends/BackendHealthStatus.java

commit 9c24ad6
Author: Niccolò Maltoni <[email protected]>
Date:   Wed Nov 27 17:22:44 2024 +0100

    refactor: extract out the RandomBackendSelector

    � Conflicts:
    �	carapace-server/src/main/java/org/carapaceproxy/server/mapper/StandardEndpointMapper.java

    � Conflicts:
    �	carapace-server/src/main/java/org/carapaceproxy/core/ProxyRequestsManager.java
    �	carapace-server/src/main/java/org/carapaceproxy/server/mapper/EndpointMapper.java
    �	carapace-server/src/main/java/org/carapaceproxy/server/mapper/StandardEndpointMapper.java

commit a8cbb5c
Author: Niccolò Maltoni <[email protected]>
Date:   Wed Nov 27 17:20:17 2024 +0100

    build: migrate logger to SLF4J APIs + Logback backend

    Squashed commit of the following:

    commit cf369f1115a8dbdeeb910307fa0d5561975dae27
    Author: Niccolò Maltoni <[email protected]>
    Date:   Thu Nov 21 09:56:10 2024 +0100

        feat: drop CarapaceLogger

    commit 95f20cc
    Author: Niccolò Maltoni <[email protected]>
    Date:   Wed Nov 20 17:24:56 2024 +0100

        fix: revert old tricky behavior

    commit 10ea9a7
    Author: Niccolò Maltoni <[email protected]>
    Date:   Fri Oct 25 18:28:58 2024 +0200

        refactor: fix logs

    commit 81d2a83
    Author: Niccolò Maltoni <[email protected]>
    Date:   Fri Nov 8 16:35:29 2024 +0100

        build: fix Surefire modules opening

    commit 5147e57
    Author: Niccolò Maltoni <[email protected]>
    Date:   Fri Nov 8 14:38:23 2024 +0100

        fix: move logback configuration to the right path

    commit b93a27f
    Author: Niccolò Maltoni <[email protected]>
    Date:   Fri Nov 8 12:10:37 2024 +0100

        build: switch logging backend to Logback

        * drop Apache Commons Logging dependency
        * add Apache Commons Logging to SLF4J adapter because of other dependencies
        * drop JUL backend for SLF4J
        * add Logback as backend for SLF4J

    commit 6bc2a5e
    Author: Niccolò Maltoni <[email protected]>
    Date:   Fri Nov 8 11:40:37 2024 +0100

        feat: migrate JUL to SLF4J

    � Conflicts:
    �	carapace-server/src/main/java/org/carapaceproxy/core/Listeners.java
    �	carapace-server/src/main/java/org/carapaceproxy/core/ProxyRequestsManager.java
    �	carapace-server/src/main/java/org/carapaceproxy/core/RequestsLogger.java
    �	carapace-server/src/main/java/org/carapaceproxy/core/RuntimeServerConfiguration.java
    �	carapace-server/src/main/java/org/carapaceproxy/server/backends/BackendHealthManager.java
    �	carapace-server/src/main/java/org/carapaceproxy/server/backends/BackendHealthStatus.java
    �	carapace-server/src/main/java/org/carapaceproxy/server/mapper/StandardEndpointMapper.java
    �	carapace-server/src/test/java/org/carapaceproxy/RawClientTest.java
    �	carapace-server/src/test/java/org/carapaceproxy/backends/RestartEndpointTest.java
    �	pom.xml
@NiccoMlt NiccoMlt linked an issue Dec 2, 2024 that may be closed by this pull request
Clean HTTP 1.1 to 2 upgrade headers #484
Closed
@NiccoMlt NiccoMlt self-assigned this Dec 2, 2024
@NiccoMlt
feat: clean HTTP 1.1 to 2 upgrade headers
7b7c5d6 
we don't want to upgrade to HTTP/2 if Carapace supports it, but the backend doesn't

fixes #484
@NiccoMlt NiccoMlt force-pushed the 484-clean-http-11-to-2-upgrade-headers branch from 6a0bb0b to 7b7c5d6 Compare December 2, 2024 14:41
@NiccoMlt NiccoMlt marked this pull request as ready for review December 2, 2024 14:42
@NiccoMlt
Copy link
Contributor Author

NiccoMlt commented Dec 2, 2024

Merge after #512

@dmercuriali dmercuriali merged commit 884cb0e into master Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmercuriali dmercuriali dmercuriali approved these changes

@hamadodene hamadodene Awaiting requested review from hamadodene

Assignees

@NiccoMlt NiccoMlt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean HTTP 1.1 to 2 upgrade headers
2 participants
@NiccoMlt @dmercuriali