Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service unavailable page customization #428

Merged
merged 1 commit into from
May 9, 2023
Merged

Service unavailable page customization #428

merged 1 commit into from
May 9, 2023

Conversation

hamadodene
Copy link
Contributor

In the current implementation, in case of problems during a request from Carapace to the server, we return the error page "500 An internal error occured" via the Publisher<Void> serveServiceNotAvailable(ProxyRequest request) function.
The error page returned is the default one and cannot be customized.

Changes:

  • In case of problems, the default error code 503 service unavailable is returned
  • Added dynamic sys prop default.action.serviceunavailable to set up your own custom error page

@hamadodene hamadodene linked an issue May 4, 2023 that may be closed by this pull request
500 Default page is served in case of Exception #426
Closed
@hamadodene hamadodene requested a review from pv3ntur1 May 4, 2023 14:52
@hamadodene hamadodene requested a review from dmercuriali May 8, 2023 15:26
@pv3ntur1 pv3ntur1 merged commit 7188821 into diennea:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmercuriali dmercuriali dmercuriali approved these changes

@pv3ntur1 pv3ntur1 pv3ntur1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

500 Default page is served in case of Exception
3 participants
@hamadodene @pv3ntur1 @dmercuriali