NullPointerException when http header host is null #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamadodene
force-pushed
the
bug/null-http-header-host
branch
4 times, most recently
from
7eed82c to
6986935
Compare
hamadodene
force-pushed
the
bug/null-http-header-host
branch
3 times, most recently
from
2b4ac25 to
a8b7424
Compare
dmercuriali
requested changes
Apr 12, 2023
| @@ -133,6 +133,8 @@ public Publisher<Void> processRequest(ProxyRequest request) { | |||
| return serveInternalErrorMessage(request); | |||
| case MAINTENANCE_MODE: | |||
| return serverMaintenanceMessage(request); | |||
| case BAD_REQUEST: | |||
| return serverBadRequestMessage(request); | |||
There was a problem hiding this comment.
serveBadRequestMessage
pv3ntur1
requested changes
Apr 14, 2023
| return requestHostname.substring(0, colonIndex); | ||
| } | ||
| } catch (NumberFormatException e) { | ||
| return ""; |
There was a problem hiding this comment.
Maybe in that case is it better to return badRequest?
There was a problem hiding this comment.
@pv3nturi Fixed
| @@ -171,6 +174,27 @@ public String getRequestHostname() { | |||
| return request.requestHeaders().get(HttpHeaderNames.HOST); | |||
| } | |||
|
|
|||
| public String getHostname() { | |||
| String requestHostname = getRequestHostname(); | |||
| int colonIndex = requestHostname.indexOf(":"); | |||
There was a problem hiding this comment.
@pv3nturi Fixed
hamadodene
force-pushed
the
bug/null-http-header-host
branch
2 times, most recently
from
48e300f to
55bdd0b
Compare
hamadodene
force-pushed
the
bug/null-http-header-host
branch
2 times, most recently
from
f070a08 to
84a17b8
Compare
|
@pv3nturi PTAL |
pv3ntur1
approved these changes
May 4, 2023
hamadodene
force-pushed
the
bug/null-http-header-host
branch
from
84a17b8 to
88d839c
Compare
dmercuriali
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#412
As per RFC, if host header is missing or wrong the response must be 400 Bad request.
See https://www.rfc-editor.org/rfc/rfc2616#page-38
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Host
the error page can be customized by setting:
default.action.badrequest=custom_action