-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Epol EpollEventLoopGroup if supported by OS #416
Conversation
590d3a6
to
aff8f3e
Compare
aff8f3e
to
04e3db7
Compare
@pv3nturi @NiccoMlt I also made the keepAlive options configurable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but you'd better to add a few tests to check for property names typo.
1e52285
to
363a1e2
Compare
363a1e2
to
e30d04b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
#415
EpollEventLoopGroup vs. NioEventLoopGroupand in high load scenarios could provide better performance in:
It would be good to include the ability to switch to EpollEventLoopGroup if the operating system supports it.
For listener- example: