Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Epol EpollEventLoopGroup if supported by OS #416

Merged
merged 5 commits into from
Feb 28, 2023

Conversation

hamadodene
Copy link
Contributor

@hamadodene hamadodene commented Feb 27, 2023

#415

EpollEventLoopGroup vs. NioEventLoopGroupand in high load scenarios could provide better performance in:

  • CPU usage
  • Memory usage
  • Allocations

It would be good to include the ability to switch to EpollEventLoopGroup if the operating system supports it.

For listener- example:

listener.1.keepalive=true|false 
listener.1.keepaliveidle=300
listener.1.keepaliveinterval=60
listener.1.keepalivecount=8
listener.1.maxkeepaliverequests=1000

@hamadodene hamadodene marked this pull request as draft February 27, 2023 17:57
@hamadodene
Copy link
Contributor Author

hamadodene commented Feb 27, 2023

@pv3nturi @NiccoMlt I also made the keepAlive options configurable.
Added keepAlive options on server side as well.

@hamadodene hamadodene requested a review from pv3ntur1 February 27, 2023 18:38
@hamadodene hamadodene marked this pull request as ready for review February 27, 2023 19:25
Copy link
Contributor

@pv3ntur1 pv3ntur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you'd better to add a few tests to check for property names typo.

Copy link
Contributor

@pv3ntur1 pv3ntur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hamadodene hamadodene merged commit 5cebb55 into diennea:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to use Epol EpollEventLoopGroup if supported by OS Make listener/Client options configurable
2 participants