Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate > sync certificates locally #324 #379

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

pv3ntur1
Copy link
Contributor

@pv3ntur1 pv3ntur1 commented Oct 17, 2022

Addes these dynamic props:

  • dynamiccertificatesmanager.localcertificates.store.path: to enable the local store of acme certificates to specified path

  • dynamiccertificatesmanager.localcertificates.peers.ids: to enable the local store for specific peers (default is enabled for all pees)

All acme certificates are dumped in local storage when became AVAILABLE or when forced from admin (by dumping a specified cert or all of them).

Added support to attach data to zookeeper events.
Also, the column privateKey of digital_certificates table has been dropped.
Finally a fix to maintenance mode , buttons and sidebar styles

@pv3ntur1 pv3ntur1 force-pushed the enhancement/#324 branch 12 times, most recently from b6f57de to b9d2811 Compare October 18, 2022 15:13
@pv3ntur1 pv3ntur1 self-assigned this Oct 19, 2022
@pv3ntur1 pv3ntur1 requested a review from hamadodene October 19, 2022 06:37
@pv3ntur1 pv3ntur1 force-pushed the enhancement/#324 branch 2 times, most recently from d793510 to c3564e9 Compare October 19, 2022 08:44
@pv3ntur1 pv3ntur1 requested a review from dmercuriali October 19, 2022 08:52
@pv3ntur1 pv3ntur1 force-pushed the enhancement/#324 branch 4 times, most recently from 246fccf to 9870b84 Compare October 19, 2022 12:09
Copy link
Contributor

@hamadodene hamadodene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
i tested this branch and all is ok.

@pv3ntur1 pv3ntur1 merged commit a76f0ad into master Oct 26, 2022
@pv3ntur1 pv3ntur1 deleted the enhancement/#324 branch October 26, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificate > Generate certificates in file + key format Certificate > sync certificates locally
2 participants