Listeners > BootSSLContext: improve locking access to cached sslConte… #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
reviewed
Jun 7, 2021
| LOG.log(Level.FINER, "resolve SNI mapping " + sniHostname + ", key: " + key); | ||
| private final class ListenerSniMapping implements io.netty.util.AsyncMapping<String, SslContext> { | ||
|
|
||
| private final Map<String, SslContext> listenerSslContexts = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
no need to be Concurrent as is accessed only by this thread
| return bootSslContext(listener, choosen); | ||
| } catch (ConfigurationNotValidException err) { | ||
| throw new RuntimeException(err); | ||
| sslContext = bootSslContext(listener, choosen); |
There was a problem hiding this comment.
idk if you did it on purpose, but now there is a possibility where more than one listener will create the SslContext for the same key
btw this is a less locking-situation so I hope this will decrease latency (maybe with more CPU usages in some cases)
| throw new RuntimeException(err); | ||
| sslContext = bootSslContext(listener, choosen); | ||
| listenerSslContexts.put(key, sslContext); | ||
| sslContexts.put(key, sslContext); |
There was a problem hiding this comment.
sslContexts is invalidated when the config changes, we need to invalidate this local map as well
added 2 commits
June 7, 2021 11:53
pv3ntur1
added a commit
that referenced
this pull request
Jun 8, 2021
#295) * Listeners > BootSSLContext: improve locking access to cached sslContexes #294 * fix pr comments * fix cache clear Co-authored-by: Paolo Venturi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #294