Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve certificate order finalization + acme client libs bump #272

Merged
merged 3 commits into from
Mar 16, 2021

Conversation

pv3ntur1
Copy link
Contributor

@pv3ntur1 pv3ntur1 commented Mar 16, 2021

During certificate renewal/ordering, whether the order is already "valid" te order finalization fails. Now this behavior is properly managed.
Also, we're bumping acme4j and bouncycastle libs to latest version

@pv3ntur1 pv3ntur1 requested a review from nicoloboschi March 16, 2021 11:21
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pv3ntur1 pv3ntur1 changed the title Add certificate order already valid management + acme client limbs bump Improve certificate order finalization + acme client limbs bump Mar 16, 2021
@pv3ntur1 pv3ntur1 changed the title Improve certificate order finalization + acme client limbs bump Improve certificate order finalization + acme client libs bump Mar 16, 2021
@pv3ntur1 pv3ntur1 merged commit ab4df14 into master Mar 16, 2021
@pv3ntur1 pv3ntur1 deleted the bug/certificate-order-stuck-when-valid branch March 17, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants