Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certiticates > Add more info for static and manual certificates in UI #257

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Certiticates > Add more info for static and manual certificates in UI #257

merged 4 commits into from
Feb 23, 2021

Conversation

pv3ntur1
Copy link
Contributor

@pv3ntur1 pv3ntur1 commented Feb 22, 2021 •
edited
Loading

PR for #196

Changelog:

Add additional information in UI for static/manual certificates:

  • status (available/expired)
  • expiringDate
  • serialNumber

Now certificates state is no more fetched from db but from cache.

hamadodene
hamadodene approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@hamadodene hamadodene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pv3ntur1 pv3ntur1 changed the title Certiticates > Add "Expiring Date" in static and manual certificates UI Certiticates > Add more info for static and manual certificates in UI Feb 22, 2021
@pv3ntur1 pv3ntur1 mentioned this pull request Feb 22, 2021
Merged
nicoloboschi
nicoloboschi suggested changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we need to change an import in a test file IMHO

carapace-server/src/test/java/org/carapaceproxy/api/StartAPIServerTest.java Outdated Show resolved Hide resolved
nicoloboschi
nicoloboschi approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pv3ntur1 pv3ntur1 merged commit 8bf762a into master Feb 23, 2021
@pv3ntur1 pv3ntur1 deleted the feature/#196 branch February 23, 2021 09:38
pv3ntur1 pushed a commit that referenced this pull request Mar 16, 2021
Certiticates > Add more info for static and manual certificates in UI #…
ec72e69 
…257
@pv3ntur1 pv3ntur1 mentioned this pull request Mar 16, 2021
Merged
pv3ntur1 pushed a commit that referenced this pull request Mar 16, 2021
Certiticates > Add more info for static and manual certificates in UI #…
24ee42b 
…257
pv3ntur1 added a commit that referenced this pull request Mar 17, 2021
@pv3ntur1
UI Certiticates list and detail > status outdated during renewal (#274)
fe7f6e0 
* Certiticates > Add more info for static and manual certificates in UI #257

* flush cache at the end of batch update

Co-authored-by: Paolo Venturi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamadodene hamadodene hamadodene approved these changes

@nicoloboschi nicoloboschi nicoloboschi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pv3ntur1 @nicoloboschi @hamadodene