fix: page wrap=false not preventing page from breaking #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diegomura Can we get this merged and release if this looks good? |
|
Yes pls, I have the same performance issue and this fixes it 💪 |
|
please merge |
lachiejamesCTC
added a commit
to lachiejamesCTC/react-pdf
that referenced
this pull request
Oct 26, 2022
diegomura
reviewed
Nov 7, 2022
| @@ -260,6 +260,11 @@ const resolvePagination = (doc, fontStore) => { | |||
|
|
|||
| for (let i = 0; i < doc.children.length; i += 1) { | |||
| const page = doc.children[i]; | |||
| if (!page.props?.wrap) { | |||
There was a problem hiding this comment.
We should explicitely check for false here. Otherwise missing wrap prop would prevent pages from wrapping which isn't what we want
diegomura
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
<Page wrap={false}>not actually preventing a page from breaking. It also can save large amounts of time (I noticed a 50% performance increase) on pages with many elements.