Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 adjust Upload Python Package workflow #115

Merged
merged 1 commit into from
Oct 20, 2023
Merged

🔧 adjust Upload Python Package workflow #115

merged 1 commit into from
Oct 20, 2023

Conversation

ff137
Copy link
Collaborator

@ff137 ff137 commented Oct 20, 2023

only publish test packages on pull request, and not on push to main.

This is because the job will always fail on push to main, as the test package will already exist -- the same version tag would have been uploaded during the in-progress pull request.

Official packages are anyway released manually, so not needed in workflow.

only publish test packages on pull request, and not on push to main.

This is because the job will _always_ fail on push to main, as the test package will already exist -- the same version tag would have been uploaded during the in-progress pull request.

Official packages are anyway released manually, so not needed in workflow.
@ff137 ff137 requested a review from rblaine95 October 20, 2023 13:54
@ff137 ff137 self-assigned this Oct 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ff137 ff137 merged commit eddc27d into main Oct 20, 2023
5 of 6 checks passed
@ff137 ff137 deleted the ff137-patch-1 branch October 20, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants