Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #422: end-of-stream caused by multiple collector #434

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

johnsonlee
Copy link
Collaborator

No description provided.

@johnsonlee johnsonlee merged commit f675500 into didi:master Oct 8, 2023
@what-the-diff
Copy link

what-the-diff bot commented Oct 8, 2023

PR Summary

  • Introduction of Java ZIP library
    The pull request introduces java's ZIP library to enhance how our application handles ZIP file types.

  • Better ZIP file handling
    Changes have been made to the File.collect() function to improve ZIP files handling. When the function encounters a file with a .zip extension, it will process it differently from other file types. This ensures consistency and efficiency when dealing with ZIP files.

  • Collecting entries from ZIP files
    A new lambda function collection.collect(entry.name) { zip.getInputStream(entry).readBytes() } has been added within the File.collect() function which collects entries from the ZIP files. This addition significantly enhances data processing and storage.

  • Lazy data loading
    An upgrade has been added to the CompositeCollector.collect() function involving val bytes by lazy(data). This innovation prevents the "end-of-stream" error that may occur due to simultaneous access by multiple readers. Hence, it upscales the application's performance and reliability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant