Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make natDisconnect() be called upon ext module deallocation #211

Merged

Conversation

drmfinlay
Copy link
Member

These changes make it so the natDisconnect() function is called for you automatically if you forget it. No effect in-process.

These changes make it so the natDisconnect() function is called for
you automatically if you forget it.  No effect in-process.
@LexiconCode LexiconCode self-assigned this Sep 24, 2024
@LexiconCode LexiconCode added the enhancement New feature or request label Sep 24, 2024
@LexiconCode
Copy link
Member

LexiconCode commented Sep 24, 2024

So when Dragon is closed without explicitly closing out of process Natlink a the GUI?

@drmfinlay
Copy link
Member Author

No, these changes won't make out-of-process natlink disconnect on Dragon shutdown. They allow the following sort of thing to work without hanging:

>>> import natlink
>>> natlink.natConnect()
>>> exit()

@LexiconCode LexiconCode merged commit 62611ac into dictation-toolbox:master Sep 26, 2024
@drmfinlay
Copy link
Member Author

drmfinlay commented Sep 26, 2024 via email

@drmfinlay drmfinlay deleted the feat/nat-disconnect-on-py-free branch September 26, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants