Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove settings as a hard dependency for Dependency.py #681

Merged

Conversation

LexiconCode
Copy link
Member

@LexiconCode LexiconCode commented Aug 19, 2019

Description

This request removes settings as a hard dependency for Dependency.py

Related Issue

#676

Motivation and Context

This make sure that Caster checks dependencies before third party packages are called. This allows Dependency.py to check for missing or version specific dependencies.

How Has This Been Tested

This has been tested

  • Online and off-line Caster mode
  • Removal of toml dependency
  • Past existing unit tests
  • Created a test package` parsing of readme
  • Mouse grids have been tested

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My code implements all the features I wish to merge in this pull request.
  • All new and existing tests pass.

Maintainer/Reviewer Checklist

  • Basic functionality has been tested and works as claimed.
  • New documentation is clear and complete.
  • Code is clear and readable.

@LexiconCode LexiconCode added the Refactor Restructuring file structure or existing code without changing its external behavior. label Aug 19, 2019
@LexiconCode LexiconCode self-assigned this Aug 19, 2019
@LexiconCode
Copy link
Member Author

LexiconCode commented Aug 20, 2019

With the removal of Dependency.py from the Nexus. The following needs to be handled so it's not dependent on the nexus.

def mouse_alternates(mode, nexus, monitor=1):
    if nexus.dep.PIL:

Code

@LexiconCode LexiconCode merged commit 783b8eb into dictation-toolbox:master Aug 20, 2019
@LexiconCode LexiconCode deleted the settings_dependency_removal branch August 20, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Restructuring file structure or existing code without changing its external behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants