Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added store and retrieve to gitter #651

Merged

Conversation

LexiconCode
Copy link
Member

@LexiconCode LexiconCode commented Jul 16, 2019

Gitter: Added store and retrieve

Description

Added store and retrieve to enhance gitter. The default behavior is the same as the original and enhancements come in when text is selected.

Example:
bold would print out **** then the cursor would move left 2 times. Next dictate example test Final result being **example test**.

With the new commands highlighting example test and say bold produces the final result result **example test**.

Limitations
I excluded utilizing it on commands that were multiline. Store and retrieve does not handle multiline execution well. Waiting for Merged #652 as a fix.

Possible Planned Features
A feature yet to implement is if no text is selected to carry out an action of moving the cursor as needed. Done

Related Issue

#650

Motivation and Context

Leverages store and retrieve to highlight text. Current features it only leverages the keyboard this allows greater mixed input from selecting text Mouse or MouseGrids.

How Has This Been Tested

It's been tested within the gitter with single-line highlighted to store and retrieve.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue or bug)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Renamed existing command phrases (we discourage this without a strong rationale).

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have checked that my code does not duplicate functionality elsewhere in Caster.
    not applicable).
  • My code implements all the features I wish to merge in this pull request.
  • Included change to the documentation <header_size> header.
  • All new and existing tests pass.

Maintainer/Reviewer Checklist

Waiting on #652

  • Basic functionality has been tested and works as claimed.
  • New documentation is clear and complete.
  • Code is clear and readable.

@LexiconCode LexiconCode added the Enhancement Enhancement of an existing feature label Jul 16, 2019
@LexiconCode LexiconCode self-assigned this Jul 16, 2019
@LexiconCode LexiconCode added the Grammar Related to a grammar for an application or programming language. label Jul 16, 2019
@LexiconCode LexiconCode added the Waiting For Issue/PR Another open issue/PR (in caster or upstream) must be completed before this can be addressed. label Jul 16, 2019
@LexiconCode LexiconCode removed the Waiting For Issue/PR Another open issue/PR (in caster or upstream) must be completed before this can be addressed. label Jul 16, 2019
@LexiconCode LexiconCode merged commit 16e557b into dictation-toolbox:master Jul 16, 2019
@LexiconCode LexiconCode deleted the Gitter-store/retrieve branch July 16, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancement of an existing feature Grammar Related to a grammar for an application or programming language.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant